Test {{in-element}} instead of deprecated {{-in-element}}
#1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Canary tests will fail because of: |
mydea
force-pushed
the
fn/test-in-element
branch
from
027f628 to
b6ceca7
Compare
Contributor
Actually 3.8 is failing. Probably because the error is thrown at build-time by the AST transform (which is not taking your if-clause into account), at least that's what I would assume. Maybe adding https://github.com/ember-polyfills/ember-in-element-polyfill as a devDependency instead of the Ember version check would help? |
mydea
force-pushed
the
fn/test-in-element
branch
from
b6ceca7 to
5dfc343
Compare
Contributor
Author
|
Hmm, interesting! I changed the test to just always run and use |
rwjblue
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to failing tests on Canary, where
{{-in-element}}is removed.This updates the test to test the
{{in-element}}helper on ember versions upwards of 3.20. I did not include an alternate branch to test{{-in-element}}on older versions because I figured that is kind of repetitive and we can assume they work the same.